staging: rtl8192e: Remove dead code from _rtl92e_if_check_reset()
authorPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Sun, 1 Oct 2023 13:44:06 +0000 (15:44 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Oct 2023 07:58:46 +0000 (09:58 +0200)
The return value of _rtl92e_tx_check_stuck() and _rtl92e_rx_check_stuck()
can only be RESET_TYPE_SILENT or RESET_TYPE_NORESET. This functions are
only used in _rtl92e_if_check_reset(). In _rtl92e_if_check_reset() the
return values are checked for RESET_TYPE_NORMAL which cannot occur.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/5f29332205dd76896e981fa627925d62a6bf7f63.1696165351.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl8192e/rtl_core.c

index 87f5441fbb10d01cfa730163c05a2c71e8d622c5..f67923ccf7903ed1efe7fc1f32654990cc260de6 100644 (file)
@@ -975,12 +975,7 @@ static enum reset_type _rtl92e_if_check_reset(struct net_device *dev)
            (priv->rtllib->link_state == MAC80211_LINKED))
                RxResetType = _rtl92e_rx_check_stuck(dev);
 
-       if (TxResetType == RESET_TYPE_NORMAL ||
-           RxResetType == RESET_TYPE_NORMAL) {
-               netdev_info(dev, "%s(): TxResetType is %d, RxResetType is %d\n",
-                           __func__, TxResetType, RxResetType);
-               return RESET_TYPE_NORMAL;
-       } else if (TxResetType == RESET_TYPE_SILENT ||
+       if (TxResetType == RESET_TYPE_SILENT ||
                   RxResetType == RESET_TYPE_SILENT) {
                netdev_info(dev, "%s(): TxResetType is %d, RxResetType is %d\n",
                            __func__, TxResetType, RxResetType);