clk: fractional-divider: Use bit operations consistently
authorAndy Shevchenko <andy.shevchenko@gmail.com>
Sun, 3 Mar 2024 12:07:32 +0000 (14:07 +0200)
committerStephen Boyd <sboyd@kernel.org>
Sat, 9 Mar 2024 01:07:11 +0000 (17:07 -0800)
Use BIT() where makes sense. This alings usage of bit operations
in the same pieces of code. Moreover, strictly speaking by the
letter of the C standard, left shift of 1 by 31 bits is UB (undefined
behaviour), switching to BIT() addresses that as well.

Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20240303120732.240355-1-andy.shevchenko@gmail.com
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/clk-fractional-divider.c

index bd882c45385bbd90e4ffc58f611793a5a906fb08..da057172cc90f145743a4f7dfd71870bd63b564b 100644 (file)
@@ -140,8 +140,8 @@ void clk_fractional_divider_general_approximation(struct clk_hw *hw,
        }
 
        if (fd->flags & CLK_FRAC_DIVIDER_ZERO_BASED) {
-               max_m = 1 << fd->mwidth;
-               max_n = 1 << fd->nwidth;
+               max_m = BIT(fd->mwidth);
+               max_n = BIT(fd->nwidth);
        } else {
                max_m = GENMASK(fd->mwidth - 1, 0);
                max_n = GENMASK(fd->nwidth - 1, 0);
@@ -182,8 +182,8 @@ static int clk_fd_set_rate(struct clk_hw *hw, unsigned long rate,
        u32 val;
 
        if (fd->flags & CLK_FRAC_DIVIDER_ZERO_BASED) {
-               max_m = 1 << fd->mwidth;
-               max_n = 1 << fd->nwidth;
+               max_m = BIT(fd->mwidth);
+               max_n = BIT(fd->nwidth);
        } else {
                max_m = GENMASK(fd->mwidth - 1, 0);
                max_n = GENMASK(fd->nwidth - 1, 0);