clk: imx: Use div64_ul instead of do_div
authorChangcheng Deng <deng.changcheng@zte.com.cn>
Thu, 18 Nov 2021 08:06:34 +0000 (08:06 +0000)
committerAbel Vesa <abel.vesa@nxp.com>
Mon, 22 Nov 2021 13:29:23 +0000 (15:29 +0200)
do_div() does a 64-by-32 division. Here the divisor is an unsigned long
which on some platforms is 64 bit wide. So use div64_ul instead of do_div
to avoid a possible truncation.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
Link: https://lore.kernel.org/r/20211118080634.165275-1-deng.changcheng@zte.com.cn
Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
drivers/clk/imx/clk-pllv3.c

index 20ee9611ba6e3934acc6f62281a8d5a2ce4ca79c..eea32f87c60aa98cb785c0534aac36a4b60809f3 100644 (file)
@@ -247,7 +247,7 @@ static long clk_pllv3_av_round_rate(struct clk_hw *hw, unsigned long rate,
        div = rate / parent_rate;
        temp64 = (u64) (rate - div * parent_rate);
        temp64 *= mfd;
-       do_div(temp64, parent_rate);
+       temp64 = div64_ul(temp64, parent_rate);
        mfn = temp64;
 
        temp64 = (u64)parent_rate;
@@ -277,7 +277,7 @@ static int clk_pllv3_av_set_rate(struct clk_hw *hw, unsigned long rate,
        div = rate / parent_rate;
        temp64 = (u64) (rate - div * parent_rate);
        temp64 *= mfd;
-       do_div(temp64, parent_rate);
+       temp64 = div64_ul(temp64, parent_rate);
        mfn = temp64;
 
        val = readl_relaxed(pll->base);
@@ -334,7 +334,7 @@ static struct clk_pllv3_vf610_mf clk_pllv3_vf610_rate_to_mf(
                /* rate = parent_rate * (mfi + mfn/mfd) */
                temp64 = rate - parent_rate * mf.mfi;
                temp64 *= mf.mfd;
-               do_div(temp64, parent_rate);
+               temp64 = div64_ul(temp64, parent_rate);
                mf.mfn = temp64;
        }