drm/panel: truly-nt35597: Don't log an error when DSI host can't be found
authorNícolas F. R. A. Prado <nfraprado@collabora.com>
Mon, 15 Apr 2024 21:49:37 +0000 (17:49 -0400)
committerRobert Foss <rfoss@kernel.org>
Tue, 16 Apr 2024 13:19:08 +0000 (15:19 +0200)
Given that failing to find a DSI host causes the driver to defer probe,
make use of dev_err_probe() to log the reason. This makes the defer
probe reason available and avoids alerting userspace about something
that is not necessarily an error.

Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240415-anx7625-defer-log-no-dsi-host-v3-9-619a28148e5c@collabora.com
drivers/gpu/drm/panel/panel-truly-nt35597.c

index b73448cf349d2c40e8442a268bae304b6cfbe830..d447db912a61ec958a4718ce49454f5f706e41db 100644 (file)
@@ -550,10 +550,8 @@ static int truly_nt35597_probe(struct mipi_dsi_device *dsi)
 
        dsi1_host = of_find_mipi_dsi_host_by_node(dsi1);
        of_node_put(dsi1);
-       if (!dsi1_host) {
-               dev_err(dev, "failed to find dsi host\n");
-               return -EPROBE_DEFER;
-       }
+       if (!dsi1_host)
+               return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n");
 
        /* register the second DSI device */
        dsi1_device = mipi_dsi_device_register_full(dsi1_host, &info);