projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c956910
)
drivers: net: xgene: Do not check for 0 return after calling platform_get_irq()
author
Ruan Jinjie
<ruanjinjie@huawei.com>
Wed, 2 Aug 2023 09:06:57 +0000
(17:06 +0800)
committer
Paolo Abeni
<pabeni@redhat.com>
Thu, 3 Aug 2023 12:50:15 +0000
(14:50 +0200)
It is not possible for platform_get_irq() to return 0. Use the
return value from platform_get_irq().
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Link:
https://lore.kernel.org/r/20230802090657.969923-1-ruanjinjie@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/apm/xgene/xgene_enet_main.c
patch
|
blob
|
history
diff --git
a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index 390671640388bd5d1b7f26d14f50499de5f98190..41d96f4b23d86b23bb8d69e8c130fdf4e141d001 100644
(file)
--- a/
drivers/net/ethernet/apm/xgene/xgene_enet_main.c
+++ b/
drivers/net/ethernet/apm/xgene/xgene_enet_main.c
@@
-1632,7
+1632,7
@@
static int xgene_enet_get_irqs(struct xgene_enet_pdata *pdata)
for (i = 0; i < max_irqs; i++) {
ret = platform_get_irq(pdev, i);
- if (ret <
=
0) {
+ if (ret < 0) {
if (pdata->phy_mode == PHY_INTERFACE_MODE_XGMII) {
max_irqs = i;
pdata->rxq_cnt = max_irqs / 2;
@@
-1640,7
+1640,7
@@
static int xgene_enet_get_irqs(struct xgene_enet_pdata *pdata)
pdata->cq_cnt = max_irqs / 2;
break;
}
- return ret
? : -ENXIO
;
+ return ret;
}
pdata->irqs[i] = ret;
}