tracing: Add a trace print when traceoff_on_warning is triggered
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Fri, 29 May 2020 14:46:32 +0000 (10:46 -0400)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Mon, 1 Jun 2020 12:23:47 +0000 (08:23 -0400)
When "traceoff_on_warning" is enabled and a warning happens, there can still
be many trace events happening on other CPUs between the time the warning
occurred and the last trace event on that same CPU. This can cause confusion
in examining the trace, as it may not be obvious where the warning happened.
By adding a trace print into the trace just before disabling tracing, it
makes it obvious where the warning occurred, and the developer doesn't have
to look at other means to see what CPU it occurred on.

Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace.c

index 29615f15a820b2f67d66af8084bfcd13936ed9c3..760fd102dbe245582c543db4e5cd44b64471eb6c 100644 (file)
@@ -1299,8 +1299,11 @@ EXPORT_SYMBOL_GPL(tracing_off);
 
 void disable_trace_on_warning(void)
 {
-       if (__disable_trace_on_warning)
+       if (__disable_trace_on_warning) {
+               trace_array_printk_buf(global_trace.array_buffer.buffer, _THIS_IP_,
+                       "Disabling tracing due to warning\n");
                tracing_off();
+       }
 }
 
 /**