bcachefs: Fix bch2_verify_insert_pos()
authorKent Overstreet <kent.overstreet@gmail.com>
Tue, 26 Nov 2019 22:18:23 +0000 (17:18 -0500)
committerKent Overstreet <kent.overstreet@linux.dev>
Sun, 22 Oct 2023 21:08:32 +0000 (17:08 -0400)
We were calling __btree_node_key_to_offset() on a key that wasn't in the
btree node.

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/bset.c

index 189a187bc080bbf4b10f4b3d3ace39bb711dde59..a0bd6af671900c85757f9dbf68f673cbf0667d7e 100644 (file)
@@ -241,10 +241,9 @@ void bch2_verify_insert_pos(struct btree *b, struct bkey_packed *where,
                bch2_bkey_to_text(&PBUF(buf2), &k2);
 
                panic("prev > insert:\n"
-                     "prev    key %5u %s\n"
-                     "insert  key %5u %s\n",
-                      __btree_node_key_to_offset(b, prev), buf1,
-                      __btree_node_key_to_offset(b, insert), buf2);
+                     "prev    key %s\n"
+                     "insert  key %s\n",
+                     buf1, buf2);
        }
 #endif
 #if 0
@@ -263,10 +262,9 @@ void bch2_verify_insert_pos(struct btree *b, struct bkey_packed *where,
                bch2_bkey_to_text(&PBUF(buf2), &k2);
 
                panic("insert > next:\n"
-                     "insert  key %5u %s\n"
-                     "next    key %5u %s\n",
-                      __btree_node_key_to_offset(b, insert), buf1,
-                      __btree_node_key_to_offset(b, next), buf2);
+                     "insert  key %s\n"
+                     "next    key %s\n",
+                     buf1, buf2);
        }
 #endif
 }