serial: 8250_dw: Hide a cast in dw8250_serial_inq()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 12 Apr 2024 17:39:37 +0000 (20:39 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Apr 2024 11:14:09 +0000 (13:14 +0200)
dw8250_serial_inq() uses unsigned int variable to store 8-bit value.
Due to that it needs a cast which can be avoided by switching to use
u8 instead of unsigned int.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20240412173937.187442-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_dw.c

index 994604c77058d0718a34ab724d6d882f130e2a9f..db0e67186a8bf6cb8d1a5238d053f8fb623a36aa 100644 (file)
@@ -185,9 +185,7 @@ static unsigned int dw8250_serial_in(struct uart_port *p, int offset)
 #ifdef CONFIG_64BIT
 static unsigned int dw8250_serial_inq(struct uart_port *p, int offset)
 {
-       unsigned int value;
-
-       value = (u8)__raw_readq(p->membase + (offset << p->regshift));
+       u8 value = __raw_readq(p->membase + (offset << p->regshift));
 
        return dw8250_modify_msr(p, offset, value);
 }