projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f03d95f
)
staging: ccree: remove extraneous spin_unlock_bh() in error handler
author
Ian Chard
<ian@chard.org>
Wed, 10 May 2017 09:20:59 +0000
(10:20 +0100)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Mon, 15 May 2017 09:48:44 +0000
(11:48 +0200)
An early error handler in send_request() tries to release a spinlock,
but the lock isn't acquired until the loop below it is entered.
Signed-off-by: Ian Chard <ian@chard.org>
Acked-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ccree/ssi_request_mgr.c
patch
|
blob
|
history
diff --git
a/drivers/staging/ccree/ssi_request_mgr.c
b/drivers/staging/ccree/ssi_request_mgr.c
index 522bd62c102eafe592349006206f2916ad67b15b..8611adf3bb2e9e8f42d5b210db9a0d20670085c2 100644
(file)
--- a/
drivers/staging/ccree/ssi_request_mgr.c
+++ b/
drivers/staging/ccree/ssi_request_mgr.c
@@
-376,7
+376,6
@@
int send_request(
rc = ssi_power_mgr_runtime_get(&drvdata->plat_dev->dev);
if (rc != 0) {
SSI_LOG_ERR("ssi_power_mgr_runtime_get returned %x\n",rc);
- spin_unlock_bh(&req_mgr_h->hw_lock);
return rc;
}
#endif