KEYS: remove redundant memset
authorTom Rix <trix@redhat.com>
Wed, 22 Jul 2020 13:46:10 +0000 (06:46 -0700)
committerDavid Howells <dhowells@redhat.com>
Thu, 21 Jan 2021 16:16:09 +0000 (16:16 +0000)
Reviewing use of memset in keyctl_pkey.c

keyctl_pkey_params_get prologue code to set params up

memset(params, 0, sizeof(*params));
params->encoding = "raw";

keyctl_pkey_query has the same prologue
and calls keyctl_pkey_params_get.

So remove the prologue.

Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Ben Boeckel <mathstuf@gmail.com>
security/keys/keyctl_pkey.c

index 931d8dfb4a7f42172a934236d046d19de4130c86..5de0d599a2748f50f3f4b144b8440f08bc57581b 100644 (file)
@@ -166,8 +166,6 @@ long keyctl_pkey_query(key_serial_t id,
        struct kernel_pkey_query res;
        long ret;
 
-       memset(&params, 0, sizeof(params));
-
        ret = keyctl_pkey_params_get(id, _info, &params);
        if (ret < 0)
                goto error;