media: v4l: ioctl: Allow drivers to fill in the format description
authorSakari Ailus <sakari.ailus@linux.intel.com>
Mon, 26 Nov 2018 11:07:29 +0000 (06:07 -0500)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 3 Dec 2018 19:41:15 +0000 (14:41 -0500)
The v4l_fill_fmtdesc() function does a good job in filling in pixelformat
description. While generally all drivers should depend on this function
doing the job, staging drivers that use their own formats may not.

Allow staging drivers to fill in their own formats by checking whether the
description begins with a non-nil character before issuing the warning.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Suggested-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/v4l2-core/v4l2-ioctl.c

index 363be5bb79420f3aa387009a055f75aa868b5517..b9616b1f227bdddb144ee30122586ebde20aff3a 100644 (file)
@@ -1340,9 +1340,9 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
                case V4L2_PIX_FMT_MT21C:        descr = "Mediatek Compressed Format"; break;
                case V4L2_PIX_FMT_SUNXI_TILED_NV12: descr = "Sunxi Tiled NV12 Format"; break;
                default:
-                       WARN(1, "Unknown pixelformat 0x%08x\n", fmt->pixelformat);
                        if (fmt->description[0])
                                return;
+                       WARN(1, "Unknown pixelformat 0x%08x\n", fmt->pixelformat);
                        flags = 0;
                        snprintf(fmt->description, sz, "%c%c%c%c%s",
                                        (char)(fmt->pixelformat & 0x7f),