sierra-ms: do not call scsi_get_host_dev()
authorHannes Reinecke <hare@suse.de>
Tue, 5 May 2020 14:30:19 +0000 (16:30 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 May 2020 12:20:00 +0000 (14:20 +0200)
scsi_get_host_dev() will create a virtual device such that either
the target id is ignored from scanning (if 'this_id' is set to
something which can be reached during scanning) or if the driver
needs a scsi device for the HBA to send commands to.
Neither is true for sierra-ms; 'this_id' remains at the default
value '-1' and the created device is never ever used within
the driver.
So kill it.

Signed-off-by: Hannes Reinecke <hare@suse.de>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20200505143019.57418-1-hare@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/storage/sierra_ms.c

index e605cbc3d8bf2da8645dbf456808f63faf65f74a..b9f78ef3edc3409e7d9f4bd794a2dd520d4e4009 100644 (file)
@@ -129,15 +129,11 @@ int sierra_ms_init(struct us_data *us)
        int result, retries;
        struct swoc_info *swocInfo;
        struct usb_device *udev;
-       struct Scsi_Host *sh;
 
        retries = 3;
        result = 0;
        udev = us->pusb_dev;
 
-       sh = us_to_host(us);
-       scsi_get_host_dev(sh);
-
        /* Force Modem mode */
        if (swi_tru_install == TRU_FORCE_MODEM) {
                usb_stor_dbg(us, "SWIMS: Forcing Modem Mode\n");