mtd: rawnand: omap2: Fix check 0 for platform_get_irq()
authorYi Yang <yiyang13@huawei.com>
Mon, 21 Aug 2023 08:46:22 +0000 (16:46 +0800)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Mon, 11 Sep 2023 15:49:56 +0000 (17:49 +0200)
Refer to commit a85a6c86c25b ("driver core: platform: Clarify that IRQ
0 is invalid"). Do not check 0 for platform_get_irq(), because
platform_get_irq() never return zero, and use the return error code of
platform_get_irq() instead of -ENODEV.

Signed-off-by: Yi Yang <yiyang13@huawei.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20230821084622.218442-1-yiyang13@huawei.com
drivers/mtd/nand/raw/omap2.c

index c45bef6158e7ac773b0bf0bbe8a3835746a14198..cf76afc6c0edc2d7699b6b5e0b72058140a71520 100644 (file)
@@ -1881,8 +1881,8 @@ static int omap_nand_attach_chip(struct nand_chip *chip)
 
        case NAND_OMAP_PREFETCH_IRQ:
                info->gpmc_irq_fifo = platform_get_irq(info->pdev, 0);
-               if (info->gpmc_irq_fifo <= 0)
-                       return -ENODEV;
+               if (info->gpmc_irq_fifo < 0)
+                       return info->gpmc_irq_fifo;
                err = devm_request_irq(dev, info->gpmc_irq_fifo,
                                       omap_nand_irq, IRQF_SHARED,
                                       "gpmc-nand-fifo", info);
@@ -1894,8 +1894,8 @@ static int omap_nand_attach_chip(struct nand_chip *chip)
                }
 
                info->gpmc_irq_count = platform_get_irq(info->pdev, 1);
-               if (info->gpmc_irq_count <= 0)
-                       return -ENODEV;
+               if (info->gpmc_irq_count < 0)
+                       return info->gpmc_irq_count;
                err = devm_request_irq(dev, info->gpmc_irq_count,
                                       omap_nand_irq, IRQF_SHARED,
                                       "gpmc-nand-count", info);