media: rcar-fcp: use pm_runtime_resume_and_get()
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 23 Apr 2021 15:19:19 +0000 (17:19 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 20 May 2021 14:02:36 +0000 (16:02 +0200)
Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
added pm_runtime_resume_and_get() in order to automatically handle
dev->power.usage_count decrement on errors.

Use the new API, in order to cleanup the error check logic.

As a bonus, pm_runtime_resume_and_get() always return 0 on success.
So, the code can be simplified.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/rcar-fcp.c

index 5c03318ae07b70cf1f6a062fb9763c8ba12edddb..eb59a3ba6d0fe925620290956aa6413d4b0a9ae2 100644 (file)
@@ -96,18 +96,10 @@ EXPORT_SYMBOL_GPL(rcar_fcp_get_device);
  */
 int rcar_fcp_enable(struct rcar_fcp_device *fcp)
 {
-       int ret;
-
        if (!fcp)
                return 0;
 
-       ret = pm_runtime_get_sync(fcp->dev);
-       if (ret < 0) {
-               pm_runtime_put_noidle(fcp->dev);
-               return ret;
-       }
-
-       return 0;
+       return pm_runtime_resume_and_get(fcp->dev);
 }
 EXPORT_SYMBOL_GPL(rcar_fcp_enable);