media: camss: Replace trace_printk() with dev_dbg()
authorRobert Foss <robert.foss@linaro.org>
Tue, 16 Mar 2021 17:19:12 +0000 (18:19 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 22 Mar 2021 11:15:29 +0000 (12:15 +0100)
trace_printk() should not be used in production code,
since extra memory is used for special buffers whenever
trace_puts() is used.

Replace it with dev_dbg() which provides all of the desired
debugging functionality.

Signed-off-by: Robert Foss <robert.foss@linaro.org>
Suggested-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/qcom/camss/camss-vfe-4-1.c
drivers/media/platform/qcom/camss/camss-vfe-4-7.c

index a1b56b89130d24507d32b85b3c2eff3caff7d439..85b9bcbc7321e74ae5b1c36a9707766f38979474 100644 (file)
@@ -12,6 +12,7 @@
 #include <linux/io.h>
 #include <linux/iopoll.h>
 
+#include "camss.h"
 #include "camss-vfe.h"
 
 #define VFE_0_HW_VERSION               0x000
@@ -936,8 +937,8 @@ static irqreturn_t vfe_isr(int irq, void *dev)
 
        vfe->ops->isr_read(vfe, &value0, &value1);
 
-       trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n",
-                    value0, value1);
+       dev_dbg(vfe->camss->dev, "VFE: status0 = 0x%08x, status1 = 0x%08x\n",
+               value0, value1);
 
        if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK)
                vfe->isr_ops.reset_ack(vfe);
index 84c33b8f9fe3527fd6d36457857d62576754ef50..f7e00a2de3939b1555d36c37f8e6a4c44487761e 100644 (file)
@@ -12,6 +12,7 @@
 #include <linux/io.h>
 #include <linux/iopoll.h>
 
+#include "camss.h"
 #include "camss-vfe.h"
 
 #define VFE_0_HW_VERSION               0x000
@@ -1069,8 +1070,8 @@ static irqreturn_t vfe_isr(int irq, void *dev)
 
        vfe->ops->isr_read(vfe, &value0, &value1);
 
-       trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n",
-                    value0, value1);
+       dev_dbg(vfe->camss->dev, "VFE: status0 = 0x%08x, status1 = 0x%08x\n",
+               value0, value1);
 
        if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK)
                vfe->isr_ops.reset_ack(vfe);