bcachefs: Fix erorr path in bch2_write()
authorKent Overstreet <kent.overstreet@gmail.com>
Mon, 11 Nov 2019 18:42:10 +0000 (13:42 -0500)
committerKent Overstreet <kent.overstreet@linux.dev>
Sun, 22 Oct 2023 21:08:32 +0000 (17:08 -0400)
The error path in bch2_write wasn't updated when the end_io callback was
added to bch_write_op.

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/io.c

index 272477fb558f785c9ffb3e7df0da34de3594c368..f53eee7accc8953405b047f05bd345f86d294b43 100644 (file)
@@ -1176,7 +1176,12 @@ void bch2_write(struct closure *cl)
 err:
        if (!(op->flags & BCH_WRITE_NOPUT_RESERVATION))
                bch2_disk_reservation_put(c, &op->res);
-       closure_return(cl);
+       if (op->end_io)
+               op->end_io(op);
+       if (cl->parent)
+               closure_return(cl);
+       else
+               closure_debug_destroy(cl);
 }
 
 /* Cache promotion on read */