scsi: qlogicpti: Call scsi_done() directly
authorBart Van Assche <bvanassche@acm.org>
Thu, 7 Oct 2021 20:29:03 +0000 (13:29 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sun, 17 Oct 2021 01:31:41 +0000 (21:31 -0400)
Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-69-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qlogicpti.c

index 8e7e833a36cce2094238b4538b92a0c9b76141ec..30b5e98b5de0e53d206faac615eb9f07f24ac1c8 100644 (file)
@@ -1021,8 +1021,6 @@ static int qlogicpti_queuecommand_lck(struct scsi_cmnd *Cmnd, void (*done)(struc
        u_int out_ptr;
        int in_ptr;
 
-       Cmnd->scsi_done = done;
-
        in_ptr = qpti->req_in_ptr;
        cmd = (struct Command_Entry *) &qpti->req_cpu[in_ptr];
        out_ptr = sbus_readw(qpti->qregs + MBOX4);
@@ -1214,7 +1212,7 @@ static irqreturn_t qpti_intr(int irq, void *dev_id)
                        struct scsi_cmnd *next;
 
                        next = (struct scsi_cmnd *) dq->host_scribble;
-                       dq->scsi_done(dq);
+                       scsi_done(dq);
                        dq = next;
                } while (dq != NULL);
        }