tty: amiserial: return from receive_chars() without goto
authorJiri Slaby (SUSE) <jirislaby@kernel.org>
Tue, 21 Nov 2023 09:22:46 +0000 (10:22 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 25 Nov 2023 07:23:17 +0000 (07:23 +0000)
The 'out' label is just before 'return'. So return immediately and drop
both the label and the return. This makes the code more straightforward.

Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20231121092258.9334-6-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/amiserial.c

index 785558c65ae8052f9e76d8b64d2486da381f5ebf..b9580bb9afd3b068908a0f7756a0cd21d24abb3b 100644 (file)
@@ -230,7 +230,7 @@ static void receive_chars(struct serial_state *info)
           * should be ignored.
           */
          if (status & info->ignore_status_mask)
-           goto out;
+                 return;
 
          status &= info->read_status_mask;
 
@@ -258,8 +258,6 @@ static void receive_chars(struct serial_state *info)
        if (oe == 1)
                tty_insert_flip_char(&info->tport, 0, TTY_OVERRUN);
        tty_flip_buffer_push(&info->tport);
-out:
-       return;
 }
 
 static void transmit_chars(struct serial_state *info)