gpio: logicvc: Remove redundant error printing in logicvc_gpio_probe()
authorZhen Lei <thunder.leizhen@huawei.com>
Tue, 11 May 2021 10:06:46 +0000 (18:06 +0800)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Wed, 12 May 2021 11:35:39 +0000 (13:35 +0200)
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpio-logicvc.c

index 015632cf159f0b8b238af3d79a7df54704e2529c..992cc958a43fd1e0ff80f8ba57480339d886e8e2 100644 (file)
@@ -114,10 +114,8 @@ static int logicvc_gpio_probe(struct platform_device *pdev)
                }
 
                base = devm_ioremap_resource(dev, &res);
-               if (IS_ERR(base)) {
-                       dev_err(dev, "Failed to map I/O base\n");
+               if (IS_ERR(base))
                        return PTR_ERR(base);
-               }
 
                logicvc_gpio_regmap_config.max_register = resource_size(&res) -
                        logicvc_gpio_regmap_config.reg_stride;