crypto: qat - do not shadow error code
authorGiovanni Cabiddu <giovanni.cabiddu@intel.com>
Thu, 14 Sep 2023 09:55:46 +0000 (10:55 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 20 Sep 2023 05:15:30 +0000 (13:15 +0800)
Do not shadow the return code from adf_dev_down() in the error path of
the DEV_DOWN command.

Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Reviewed-by: Adam Guerin <adam.guerin@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/intel/qat/qat_common/adf_sysfs.c

index a8f33558d7cb85fbba3ba004233c5d9ab7fd6a4c..5e14c374ebd30459ab98ffc5bdb7acdcbe58a801 100644 (file)
@@ -60,8 +60,8 @@ static ssize_t state_store(struct device *dev, struct device_attribute *attr,
                }
 
                ret = adf_dev_down(accel_dev, true);
-               if (ret < 0)
-                       return -EINVAL;
+               if (ret)
+                       return ret;
 
                break;
        case DEV_UP: