net: dsa: qca8k: check correct variable in qca8k_phy_eth_command()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 4 Feb 2022 10:03:36 +0000 (13:03 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 5 Feb 2022 15:07:07 +0000 (15:07 +0000)
This is a copy and paste bug.  It was supposed to check "clear_skb"
instead of "write_skb".

Fixes: 2cd548566384 ("net: dsa: qca8k: add support for phy read/write with mgmt Ethernet")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/qca8k.c

index 83066af3757f0fdb92c756a68fc16ace17b45f57..bb2fbb6826ac19b3997c71ec505f069eca4cc163 100644 (file)
@@ -1018,7 +1018,7 @@ qca8k_phy_eth_command(struct qca8k_priv *priv, bool read, int phy,
 
        clear_skb = qca8k_alloc_mdio_header(MDIO_WRITE, QCA8K_MDIO_MASTER_CTRL, &clear_val,
                                            QCA8K_ETHERNET_PHY_PRIORITY, sizeof(clear_val));
-       if (!write_skb) {
+       if (!clear_skb) {
                ret = -ENOMEM;
                goto err_clear_skb;
        }