drm/msm/dpu: Remove unnecessary NULL checks
authorDrew Davenport <ddavenport@chromium.org>
Fri, 6 Sep 2019 19:23:42 +0000 (13:23 -0600)
committerRob Clark <robdclark@chromium.org>
Mon, 7 Oct 2019 15:24:29 +0000 (08:24 -0700)
drm_crtc.dev will never be NULL, so no need to check it.

Signed-off-by: Drew Davenport <ddavenport@chromium.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c

index 094d74635fb769dd8dd271014393910cf486d19f..839887a3a80ca07b2547e2b76dcde10c29540562 100644 (file)
@@ -33,11 +33,6 @@ static struct dpu_kms *_dpu_crtc_get_kms(struct drm_crtc *crtc)
 {
        struct msm_drm_private *priv;
 
-       if (!crtc->dev) {
-               DPU_ERROR("invalid device\n");
-               return NULL;
-       }
-
        priv = crtc->dev->dev_private;
        if (!priv->kms) {
                DPU_ERROR("invalid kms\n");
index ead7d657097c811655f39989a69c5a22e2a48b0c..0b9dc042d2e22678944346fd2d82f93923c4608d 100644 (file)
@@ -266,7 +266,7 @@ enum dpu_intf_mode dpu_crtc_get_intf_mode(struct drm_crtc *crtc)
 {
        struct drm_encoder *encoder;
 
-       if (!crtc || !crtc->dev) {
+       if (!crtc) {
                DPU_ERROR("invalid crtc\n");
                return INTF_MODE_NONE;
        }
@@ -694,7 +694,7 @@ static void dpu_crtc_disable(struct drm_crtc *crtc,
        unsigned long flags;
        bool release_bandwidth = false;
 
-       if (!crtc || !crtc->dev || !crtc->state) {
+       if (!crtc || !crtc->state) {
                DPU_ERROR("invalid crtc\n");
                return;
        }
@@ -766,7 +766,7 @@ static void dpu_crtc_enable(struct drm_crtc *crtc,
        struct msm_drm_private *priv;
        bool request_bandwidth;
 
-       if (!crtc || !crtc->dev) {
+       if (!crtc) {
                DPU_ERROR("invalid crtc\n");
                return;
        }