RDMA/rtrs-clt: Remove duplicated code

process_info_rsp checks that sg_cnt is zero twice.

Link: https://lore.kernel.org/r/20201023074353.21946-10-jinpu.wang@cloud.ionos.com
Signed-off-by: Gioh Kim <gi-oh.kim@cloud.ionos.com>
Signed-off-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
index 30eda2f355e1c0fede37e518bcfc8b53c50eb096..1b2821d71b46657777edc5f284f0817c936c6d28 100644 (file)
--- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
@@ -2264,8 +2264,12 @@ static int process_info_rsp(struct rtrs_clt_sess *sess,
        int i, sgi;
 
        sg_cnt = le16_to_cpu(msg->sg_cnt);
-       if (unlikely(!sg_cnt))
+       if (unlikely(!sg_cnt || (sess->queue_depth % sg_cnt))) {
+               rtrs_err(sess->clt, "Incorrect sg_cnt %d, is not multiple\n",
+                         sg_cnt);
                return -EINVAL;
+       }
+
        /*
         * Check if IB immediate data size is enough to hold the mem_id and
         * the offset inside the memory chunk.
@@ -2278,11 +2282,6 @@ static int process_info_rsp(struct rtrs_clt_sess *sess,
                          MAX_IMM_PAYL_BITS, sg_cnt, sess->chunk_size);
                return -EINVAL;
        }
-       if (unlikely(!sg_cnt || (sess->queue_depth % sg_cnt))) {
-               rtrs_err(sess->clt, "Incorrect sg_cnt %d, is not multiple\n",
-                         sg_cnt);
-               return -EINVAL;
-       }
        total_len = 0;
        for (sgi = 0, i = 0; sgi < sg_cnt && i < sess->queue_depth; sgi++) {
                const struct rtrs_sg_desc *desc = &msg->desc[sgi];