dmaengine: idma64: Make idma64_remove() return void
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fri, 14 Oct 2022 16:12:50 +0000 (18:12 +0200)
committerVinod Koul <vkoul@kernel.org>
Wed, 19 Oct 2022 13:47:35 +0000 (19:17 +0530)
The function idma64_remove() returns zero unconditionally. Make it
return void.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20221014161250.468687-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/idma64.c

index f4c07ad3be15b427a43b7c9a60e4e5d43f9a9fa2..c33087c5cd0214f23f5f595c86bedf1371f4912f 100644 (file)
@@ -600,7 +600,7 @@ static int idma64_probe(struct idma64_chip *chip)
        return 0;
 }
 
-static int idma64_remove(struct idma64_chip *chip)
+static void idma64_remove(struct idma64_chip *chip)
 {
        struct idma64 *idma64 = chip->idma64;
        unsigned short i;
@@ -618,8 +618,6 @@ static int idma64_remove(struct idma64_chip *chip)
 
                tasklet_kill(&idma64c->vchan.task);
        }
-
-       return 0;
 }
 
 /* ---------------------------------------------------------------------- */
@@ -664,7 +662,9 @@ static int idma64_platform_remove(struct platform_device *pdev)
 {
        struct idma64_chip *chip = platform_get_drvdata(pdev);
 
-       return idma64_remove(chip);
+       idma64_remove(chip);
+
+       return 0;
 }
 
 static int __maybe_unused idma64_pm_suspend(struct device *dev)