xsk: Introduce padding between ring pointers

Introduce one cache line worth of padding between the producer and
consumer pointers in all the lockless rings. This so that the HW
adjacency prefetcher will not prefetch the consumer pointer when the
producer pointer is used and vice versa. This improves throughput
performance for the l2fwd sample app with 2% on my machine with HW
prefetching turned on.

Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/1602166338-21378-1-git-send-email-magnus.karlsson@gmail.com

diff --git a/net/xdp/xsk_queue.h b/net/xdp/xsk_queue.h
index dc1dd5ef70d149572559fb7ea0fff874293e26d3..cdb9cf3cd1361f9d15c36d081abe0408cf93ab55 100644 (file)
--- a/net/xdp/xsk_queue.h
+++ b/net/xdp/xsk_queue.h
@@ -15,6 +15,10 @@
 
 struct xdp_ring {
        u32 producer ____cacheline_aligned_in_smp;
+       /* Hinder the adjacent cache prefetcher to prefetch the consumer
+        * pointer if the producer pointer is touched and vice versa.
+        */
+       u32 pad ____cacheline_aligned_in_smp;
        u32 consumer ____cacheline_aligned_in_smp;
        u32 flags;
 };