wifi: mac80211: fix ieee80211_drop_unencrypted_mgmt return type/value
authorJohannes Berg <johannes.berg@intel.com>
Fri, 29 Sep 2023 14:21:00 +0000 (16:21 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Fri, 29 Sep 2023 21:21:15 +0000 (23:21 +0200)
Somehow, I managed to botch this and pretty much completely break
wifi. My original patch did contain these changes, but I seem to
have lost them before sending to the list. Fix it now.

Reported-and-tested-by: Kalle Valo <kvalo@kernel.org>
Fixes: 6c02fab72429 ("wifi: mac80211: split ieee80211_drop_unencrypted_mgmt() return value")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/rx.c

index fb2d4a7436be67b192f49add7b904bbead9a98b6..051db97a92b4007faa1c97c71fc595522782c79e 100644 (file)
@@ -2405,7 +2405,8 @@ static int ieee80211_drop_unencrypted(struct ieee80211_rx_data *rx, __le16 fc)
        return 0;
 }
 
-static int ieee80211_drop_unencrypted_mgmt(struct ieee80211_rx_data *rx)
+static ieee80211_rx_result
+ieee80211_drop_unencrypted_mgmt(struct ieee80211_rx_data *rx)
 {
        struct ieee80211_rx_status *status = IEEE80211_SKB_RXCB(rx->skb);
        struct ieee80211_mgmt *mgmt = (void *)rx->skb->data;
@@ -2473,7 +2474,7 @@ static int ieee80211_drop_unencrypted_mgmt(struct ieee80211_rx_data *rx)
                        return RX_DROP_U_UNPROT_UNICAST_PUB_ACTION;
        }
 
-       return 0;
+       return RX_CONTINUE;
 }
 
 static ieee80211_rx_result