f2fs: show f2fs instance in printk_ratelimited

As Eric mentioned, bare printk{,_ratelimited} won't show which
filesystem instance these message is coming from, this patch tries
to show fs instance with sb->s_id field in all places we missed
before.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
index a0eef95b9e0ed0760b3bc56056c7a71a3b766ea3..ffdaba0c55d29368c435b9e8b424bba999d9967a 100644 (file)
--- a/fs/f2fs/checkpoint.c
+++ b/fs/f2fs/checkpoint.c
@@ -581,7 +581,7 @@ int f2fs_acquire_orphan_inode(struct f2fs_sb_info *sbi)
 
        if (time_to_inject(sbi, FAULT_ORPHAN)) {
                spin_unlock(&im->ino_lock);
-               f2fs_show_injection_info(FAULT_ORPHAN);
+               f2fs_show_injection_info(sbi, FAULT_ORPHAN);
                return -ENOSPC;
        }
 

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 8a80fc86a44f45a4362f77e1a199ab3ea6f90394..a034cd0ce02170a4477a4dfc2c01b0653f94cb0d 100644 (file)
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -168,9 +168,10 @@ static bool f2fs_bio_post_read_required(struct bio *bio)
 
 static void f2fs_read_end_io(struct bio *bio)
 {
-       if (time_to_inject(F2FS_P_SB(bio_first_page_all(bio)),
-                                               FAULT_READ_IO)) {
-               f2fs_show_injection_info(FAULT_READ_IO);
+       struct f2fs_sb_info *sbi = F2FS_P_SB(bio_first_page_all(bio));
+
+       if (time_to_inject(sbi, FAULT_READ_IO)) {
+               f2fs_show_injection_info(sbi, FAULT_READ_IO);
                bio->bi_status = BLK_STS_IOERR;
        }
 
@@ -192,7 +193,7 @@ static void f2fs_write_end_io(struct bio *bio)
        struct bvec_iter_all iter_all;
 
        if (time_to_inject(sbi, FAULT_WRITE_IO)) {
-               f2fs_show_injection_info(FAULT_WRITE_IO);
+               f2fs_show_injection_info(sbi, FAULT_WRITE_IO);
                bio->bi_status = BLK_STS_IOERR;
        }
 

diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
index 4033778bcbbfdbac444af9e8bacfebdb606afb0f..c967cacf979ef1cb52700d7aa34d93b649a4c19b 100644 (file)
--- a/fs/f2fs/dir.c
+++ b/fs/f2fs/dir.c
@@ -628,7 +628,7 @@ int f2fs_add_regular_entry(struct inode *dir, const struct qstr *new_name,
 
 start:
        if (time_to_inject(F2FS_I_SB(dir), FAULT_DIR_DEPTH)) {
-               f2fs_show_injection_info(FAULT_DIR_DEPTH);
+               f2fs_show_injection_info(F2FS_I_SB(dir), FAULT_DIR_DEPTH);
                return -ENOSPC;
        }
 
@@ -919,8 +919,9 @@ int f2fs_fill_dentries(struct dir_context *ctx, struct f2fs_dentry_ptr *d,
                        bit_pos++;
                        ctx->pos = start_pos + bit_pos;
                        printk_ratelimited(
-                               "%s, invalid namelen(0), ino:%u, run fsck to fix.",
-                               KERN_WARNING, le32_to_cpu(de->ino));
+                               "%sF2FS-fs (%s): invalid namelen(0), ino:%u, run fsck to fix.",
+                               KERN_WARNING, sbi->sb->s_id,
+                               le32_to_cpu(de->ino));
                        set_sbi_flag(sbi, SBI_NEED_FSCK);
                        continue;
                }

diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index c681f51e351b14079d7ff21883bace68c3c9f5e1..3f62042027884d81540b7b9b2a656fadb6d12276 100644 (file)
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -1374,9 +1374,10 @@ struct f2fs_private_dio {
 };
 
 #ifdef CONFIG_F2FS_FAULT_INJECTION
-#define f2fs_show_injection_info(type)                                 \
-       printk_ratelimited("%sF2FS-fs : inject %s in %s of %pS\n",      \
-               KERN_INFO, f2fs_fault_name[type],                       \
+#define f2fs_show_injection_info(sbi, type)                                    \
+       printk_ratelimited("%sF2FS-fs (%s) : inject %s in %s of %pS\n", \
+               KERN_INFO, sbi->sb->s_id,                               \
+               f2fs_fault_name[type],                                  \
                __func__, __builtin_return_address(0))
 static inline bool time_to_inject(struct f2fs_sb_info *sbi, int type)
 {
@@ -1396,7 +1397,7 @@ static inline bool time_to_inject(struct f2fs_sb_info *sbi, int type)
        return false;
 }
 #else
-#define f2fs_show_injection_info(type) do { } while (0)
+#define f2fs_show_injection_info(sbi, type) do { } while (0)
 static inline bool time_to_inject(struct f2fs_sb_info *sbi, int type)
 {
        return false;
@@ -1781,7 +1782,7 @@ static inline int inc_valid_block_count(struct f2fs_sb_info *sbi,
                return ret;
 
        if (time_to_inject(sbi, FAULT_BLOCK)) {
-               f2fs_show_injection_info(FAULT_BLOCK);
+               f2fs_show_injection_info(sbi, FAULT_BLOCK);
                release = *count;
                goto release_quota;
        }
@@ -2033,7 +2034,7 @@ static inline int inc_valid_node_count(struct f2fs_sb_info *sbi,
        }
 
        if (time_to_inject(sbi, FAULT_BLOCK)) {
-               f2fs_show_injection_info(FAULT_BLOCK);
+               f2fs_show_injection_info(sbi, FAULT_BLOCK);
                goto enospc;
        }
 
@@ -2148,7 +2149,8 @@ static inline struct page *f2fs_grab_cache_page(struct address_space *mapping,
                        return page;
 
                if (time_to_inject(F2FS_M_SB(mapping), FAULT_PAGE_ALLOC)) {
-                       f2fs_show_injection_info(FAULT_PAGE_ALLOC);
+                       f2fs_show_injection_info(F2FS_M_SB(mapping),
+                                                       FAULT_PAGE_ALLOC);
                        return NULL;
                }
        }
@@ -2163,7 +2165,7 @@ static inline struct page *f2fs_pagecache_get_page(
                                int fgp_flags, gfp_t gfp_mask)
 {
        if (time_to_inject(F2FS_M_SB(mapping), FAULT_PAGE_GET)) {
-               f2fs_show_injection_info(FAULT_PAGE_GET);
+               f2fs_show_injection_info(F2FS_M_SB(mapping), FAULT_PAGE_GET);
                return NULL;
        }
 
@@ -2232,7 +2234,7 @@ static inline struct bio *f2fs_bio_alloc(struct f2fs_sb_info *sbi,
                return bio;
        }
        if (time_to_inject(sbi, FAULT_ALLOC_BIO)) {
-               f2fs_show_injection_info(FAULT_ALLOC_BIO);
+               f2fs_show_injection_info(sbi, FAULT_ALLOC_BIO);
                return NULL;
        }
 
@@ -2799,7 +2801,7 @@ static inline void *f2fs_kmalloc(struct f2fs_sb_info *sbi,
        void *ret;
 
        if (time_to_inject(sbi, FAULT_KMALLOC)) {
-               f2fs_show_injection_info(FAULT_KMALLOC);
+               f2fs_show_injection_info(sbi, FAULT_KMALLOC);
                return NULL;
        }
 
@@ -2820,7 +2822,7 @@ static inline void *f2fs_kvmalloc(struct f2fs_sb_info *sbi,
                                        size_t size, gfp_t flags)
 {
        if (time_to_inject(sbi, FAULT_KVMALLOC)) {
-               f2fs_show_injection_info(FAULT_KVMALLOC);
+               f2fs_show_injection_info(sbi, FAULT_KVMALLOC);
                return NULL;
        }
 

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index f1f507f6561ad4146d9994e98913f07381fcb594..f9f3a417a0cd4bd9ee3be33ba030fefb2bcfec2d 100644 (file)
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -681,7 +681,7 @@ int f2fs_truncate(struct inode *inode)
        trace_f2fs_truncate(inode);
 
        if (time_to_inject(F2FS_I_SB(inode), FAULT_TRUNCATE)) {
-               f2fs_show_injection_info(FAULT_TRUNCATE);
+               f2fs_show_injection_info(F2FS_I_SB(inode), FAULT_TRUNCATE);
                return -EIO;
        }
 

diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index ef7686a8272280e644b8e7730f3565e50f83ce4a..24a3b6b52210eeb20fdbccfdfdec19cf72c83a54 100644 (file)
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -54,7 +54,7 @@ static int gc_thread_func(void *data)
                }
 
                if (time_to_inject(sbi, FAULT_CHECKPOINT)) {
-                       f2fs_show_injection_info(FAULT_CHECKPOINT);
+                       f2fs_show_injection_info(sbi, FAULT_CHECKPOINT);
                        f2fs_stop_checkpoint(sbi, false);
                }
 

diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
index 386ad54c13c3a3abf9812f3621328322862afd9a..502bd491336a8200861232e9b3ba60ccc94965c3 100644 (file)
--- a/fs/f2fs/inode.c
+++ b/fs/f2fs/inode.c
@@ -681,7 +681,7 @@ retry:
                err = f2fs_truncate(inode);
 
        if (time_to_inject(sbi, FAULT_EVICT_INODE)) {
-               f2fs_show_injection_info(FAULT_EVICT_INODE);
+               f2fs_show_injection_info(sbi, FAULT_EVICT_INODE);
                err = -EIO;
        }
 

diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 06fd6d77d34bb719db5a6e3e9bc81deeebbb0d49..3314a0f3405eff75c62dfc2b1d4cb9f2837891f4 100644 (file)
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -2398,7 +2398,7 @@ bool f2fs_alloc_nid(struct f2fs_sb_info *sbi, nid_t *nid)
        struct free_nid *i = NULL;
 retry:
        if (time_to_inject(sbi, FAULT_ALLOC_NID)) {
-               f2fs_show_injection_info(FAULT_ALLOC_NID);
+               f2fs_show_injection_info(sbi, FAULT_ALLOC_NID);
                return false;
        }
 

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 8bb37f8a18456732d48e5ad45fbcdb3b91b9e242..43daa9431160f032f4dadcd32feaaf74d70e5d9c 100644 (file)
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -480,7 +480,7 @@ int f2fs_commit_inmem_pages(struct inode *inode)
 void f2fs_balance_fs(struct f2fs_sb_info *sbi, bool need)
 {
        if (time_to_inject(sbi, FAULT_CHECKPOINT)) {
-               f2fs_show_injection_info(FAULT_CHECKPOINT);
+               f2fs_show_injection_info(sbi, FAULT_CHECKPOINT);
                f2fs_stop_checkpoint(sbi, false);
        }
 
@@ -1008,8 +1008,9 @@ static void __remove_discard_cmd(struct f2fs_sb_info *sbi,
 
        if (dc->error)
                printk_ratelimited(
-                       "%sF2FS-fs: Issue discard(%u, %u, %u) failed, ret: %d",
-                       KERN_INFO, dc->lstart, dc->start, dc->len, dc->error);
+                       "%sF2FS-fs (%s): Issue discard(%u, %u, %u) failed, ret: %d",
+                       KERN_INFO, sbi->sb->s_id,
+                       dc->lstart, dc->start, dc->len, dc->error);
        __detach_discard_cmd(dcc, dc);
 }
 
@@ -1149,7 +1150,7 @@ static int __submit_discard_cmd(struct f2fs_sb_info *sbi,
                dc->len += len;
 
                if (time_to_inject(sbi, FAULT_DISCARD)) {
-                       f2fs_show_injection_info(FAULT_DISCARD);
+                       f2fs_show_injection_info(sbi, FAULT_DISCARD);
                        err = -EIO;
                        goto submit;
                }