nilfs2: fix out-of-range warning
authorArnd Bergmann <arnd@arndb.de>
Thu, 28 Mar 2024 14:30:44 +0000 (15:30 +0100)
committerChristian Brauner <brauner@kernel.org>
Tue, 9 Apr 2024 08:52:12 +0000 (10:52 +0200)
clang-14 points out that v_size is always smaller than a 64KB
page size if that is configured by the CPU architecture:

fs/nilfs2/ioctl.c:63:19: error: result of comparison of constant 65536 with expression of type '__u16' (aka 'unsigned short') is always false [-Werror,-Wtautological-constant-out-of-range-compare]
        if (argv->v_size > PAGE_SIZE)
            ~~~~~~~~~~~~ ^ ~~~~~~~~~

This is ok, so just shut up that warning with a cast.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20240328143051.1069575-7-arnd@kernel.org
Fixes: 3358b4aaa84f ("nilfs2: fix problems of memory allocation in ioctl")
Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Reviewed-by: Justin Stitt <justinstitt@google.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/nilfs2/ioctl.c

index f1a01c191cf53ad17131fcf2a256f70b37d0d86c..8be471ce4f1950029e2f7479cd46f0369215b121 100644 (file)
@@ -60,7 +60,7 @@ static int nilfs_ioctl_wrap_copy(struct the_nilfs *nilfs,
        if (argv->v_nmembs == 0)
                return 0;
 
-       if (argv->v_size > PAGE_SIZE)
+       if ((size_t)argv->v_size > PAGE_SIZE)
                return -EINVAL;
 
        /*