RDMA/hns: Fix return in hns_roce_rereg_user_mr()
authorYueHaibing <yuehaibing@huawei.com>
Wed, 4 Aug 2021 12:59:39 +0000 (20:59 +0800)
committerJason Gunthorpe <jgg@nvidia.com>
Thu, 19 Aug 2021 14:12:04 +0000 (11:12 -0300)
If re-registering an MR in hns_roce_rereg_user_mr(), we should return NULL
instead of passing 0 to ERR_PTR for clarity.

Fixes: 4e9fc1dae2a9 ("RDMA/hns: Optimize the MR registration process")
Link: https://lore.kernel.org/r/20210804125939.20516-1-yuehaibing@huawei.com
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/hns/hns_roce_mr.c

index 006c84bb3f9fd83c72de4775760938cbd63b4c87..7089ac780291340e6ef51eb41174a5119a2d2464 100644 (file)
@@ -352,7 +352,9 @@ struct ib_mr *hns_roce_rereg_user_mr(struct ib_mr *ibmr, int flags, u64 start,
 free_cmd_mbox:
        hns_roce_free_cmd_mailbox(hr_dev, mailbox);
 
-       return ERR_PTR(ret);
+       if (ret)
+               return ERR_PTR(ret);
+       return NULL;
 }
 
 int hns_roce_dereg_mr(struct ib_mr *ibmr, struct ib_udata *udata)