projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
175caaf
)
drm/lima/lima_drv: Add missing unwind goto in lima_pdev_probe()
author
Harshit Mogalapalli
<harshit.m.mogalapalli@oracle.com>
Tue, 14 Mar 2023 05:27:11 +0000
(22:27 -0700)
committer
Qiang Yu
<yuq825@gmail.com>
Sun, 2 Apr 2023 10:18:37 +0000
(18:18 +0800)
Smatch reports:
drivers/gpu/drm/lima/lima_drv.c:396 lima_pdev_probe() warn:
missing unwind goto?
Store return value in err and goto 'err_out0' which has
lima_sched_slab_fini() before returning.
Fixes: a1d2a6339961 ("drm/lima: driver for ARM Mali4xx GPUs")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Link:
https://patchwork.freedesktop.org/patch/msgid/20230314052711.4061652-1-harshit.m.mogalapalli@oracle.com
drivers/gpu/drm/lima/lima_drv.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/lima/lima_drv.c
b/drivers/gpu/drm/lima/lima_drv.c
index 7b8d7178d09aac4b2849d2fafda35e19366d8c8a..39cab4a55f5728d2f8991bce764afed4b6c844d7 100644
(file)
--- a/
drivers/gpu/drm/lima/lima_drv.c
+++ b/
drivers/gpu/drm/lima/lima_drv.c
@@
-392,8
+392,10
@@
static int lima_pdev_probe(struct platform_device *pdev)
/* Allocate and initialize the DRM device. */
ddev = drm_dev_alloc(&lima_drm_driver, &pdev->dev);
- if (IS_ERR(ddev))
- return PTR_ERR(ddev);
+ if (IS_ERR(ddev)) {
+ err = PTR_ERR(ddev);
+ goto err_out0;
+ }
ddev->dev_private = ldev;
ldev->ddev = ddev;