pinctrl: aw9523: Make use of dev_err_probe()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 29 Mar 2024 10:55:22 +0000 (12:55 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 4 Apr 2024 11:16:46 +0000 (13:16 +0200)
Simplify the error handling in probe function by switching from
dev_err() to dev_err_probe().

Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Message-ID: <20240329105634.712457-9-andy.shevchenko@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-aw9523.c

index f084dad5c88f9e8b7b471b5f0ad7911352957032..fe398c59c2d114f3a2a54513b619501645312c69 100644 (file)
@@ -816,10 +816,8 @@ static int aw9523_init_irq(struct aw9523 *awi, int irq)
 
        ret = devm_request_threaded_irq(dev, irq, NULL, aw9523_irq_thread_func,
                                        IRQF_ONESHOT, dev_name(dev), awi);
-       if (ret) {
-               dev_err(dev, "Failed to request irq %d\n", irq);
-               return ret;
-       }
+       if (ret)
+               return dev_err_probe(dev, ret, "Failed to request irq %d\n", irq);
 
        girq = &awi->gpio.irq;
        gpio_irq_chip_set_chip(girq, &aw9523_irq_chip);
@@ -1016,8 +1014,7 @@ static int aw9523_probe(struct i2c_client *client)
 
        awi->pctl = devm_pinctrl_register(dev, pdesc, awi);
        if (IS_ERR(awi->pctl)) {
-               ret = PTR_ERR(awi->pctl);
-               dev_err(dev, "Cannot register pinctrl: %d", ret);
+               ret = dev_err_probe(dev, PTR_ERR(awi->pctl), "Cannot register pinctrl");
                goto err_disable_vregs;
        }