ASoC: topology: Properly access value coming from topology file
authorAmadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Fri, 27 Jan 2023 23:11:01 +0000 (00:11 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 30 Jan 2023 16:56:02 +0000 (16:56 +0000)
When accessing values coming from topology, le32_to_cpu should be used.
One of recent commits missed that.

Fixes: 86e2d14b6d1a ("ASoC: topology: Add header payload_size verification")
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Link: https://lore.kernel.org/r/20230127231111.937721-2-amadeuszx.slawinski@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-topology.c

index c3be24b2fac5560a94293ef4f83872b0704b64ff..b9addbab2b3dc528f7ba4320c40e62b62063f16a 100644 (file)
@@ -2404,7 +2404,7 @@ static int soc_valid_header(struct soc_tplg *tplg,
                return -EINVAL;
        }
 
-       if (soc_tplg_get_hdr_offset(tplg) + hdr->payload_size >= tplg->fw->size) {
+       if (soc_tplg_get_hdr_offset(tplg) + le32_to_cpu(hdr->payload_size) >= tplg->fw->size) {
                dev_err(tplg->dev,
                        "ASoC: invalid header of type %d at offset %ld payload_size %d\n",
                        le32_to_cpu(hdr->type), soc_tplg_get_hdr_offset(tplg),