platform/x86: xiaomi-wmi: Drop unnecessary NULL checks

The WMI driver core already makes sure that:

- a valid WMI device is passed to each callback
- the notify() callback runs after the probe() callback succeeds

Remove the unnecessary NULL checks.

Compile-tested only.

Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Link: https://lore.kernel.org/r/20240402143059.8456-3-W_Armin@gmx.de
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

diff --git a/drivers/platform/x86/xiaomi-wmi.c b/drivers/platform/x86/xiaomi-wmi.c
index 7efbdc111803c2e6fc62fce5b7ed6fbad418682a..cbed29ca502a6091fb29538ba1257761c829f1c3 100644 (file)
--- a/drivers/platform/x86/xiaomi-wmi.c
+++ b/drivers/platform/x86/xiaomi-wmi.c
@@ -38,7 +38,7 @@ static int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context)
        struct xiaomi_wmi *data;
        int ret;
 
-       if (wdev == NULL || context == NULL)
+       if (!context)
                return -EINVAL;
 
        data = devm_kzalloc(&wdev->dev, sizeof(struct xiaomi_wmi), GFP_KERNEL);
@@ -66,14 +66,7 @@ static int xiaomi_wmi_probe(struct wmi_device *wdev, const void *context)
 
 static void xiaomi_wmi_notify(struct wmi_device *wdev, union acpi_object *dummy)
 {
-       struct xiaomi_wmi *data;
-
-       if (wdev == NULL)
-               return;
-
-       data = dev_get_drvdata(&wdev->dev);
-       if (data == NULL)
-               return;
+       struct xiaomi_wmi *data = dev_get_drvdata(&wdev->dev);
 
        mutex_lock(&data->key_lock);
        input_report_key(data->input_dev, data->key_code, 1);