drm/i915/tv: Drop redundant null checks
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 7 Dec 2023 19:34:41 +0000 (21:34 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 8 Dec 2023 18:32:27 +0000 (20:32 +0200)
Neither 'tv_mode' or 'color_conversion' can be NULL,
so drop the pointless checks.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231207193441.20206-9-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_tv.c

index 2ee4f0d9585136e889732b59e7bd91e3498f7714..d4386cb3569e0991bc3c0c78a4415d77a7bc1998 100644 (file)
@@ -1417,9 +1417,6 @@ set_tv_mode_timings(struct drm_i915_private *dev_priv,
 static void set_color_conversion(struct drm_i915_private *dev_priv,
                                 const struct color_conversion *color_conversion)
 {
-       if (!color_conversion)
-               return;
-
        intel_de_write(dev_priv, TV_CSC_Y,
                       (color_conversion->ry << 16) | color_conversion->gy);
        intel_de_write(dev_priv, TV_CSC_Y2,
@@ -1454,9 +1451,6 @@ static void intel_tv_pre_enable(struct intel_atomic_state *state,
        int xpos, ypos;
        unsigned int xsize, ysize;
 
-       if (!tv_mode)
-               return; /* can't happen (mode_prepare prevents this) */
-
        tv_ctl = intel_de_read(dev_priv, TV_CTL);
        tv_ctl &= TV_CTL_SAVE;