media: atomisp: Remove redundant NULL check
authorXu Wang <vulab@iscas.ac.cn>
Fri, 25 Dec 2020 08:38:18 +0000 (09:38 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 22 Mar 2021 22:29:17 +0000 (23:29 +0100)
Fix warnings reported by coccicheck:
./drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c:159:4-10: WARNING: NULL check before some freeing functions is not needed.

Link: https://lore.kernel.org/linux-media/20201225083818.64588-1-vulab@iscas.ac.cn
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c

index e861777385a07bd9cf7cca9cd7afc6f0ab445b8b..823ec54b6281f84ee02c9e88d1994ec92989b655 100644 (file)
@@ -155,8 +155,7 @@ ia_css_isp_param_destroy_isp_parameters(
 
        for (mem = 0; mem < IA_CSS_NUM_MEMORIES; mem++) {
                for (pclass = 0; pclass < IA_CSS_NUM_PARAM_CLASSES; pclass++) {
-                       if (mem_params->params[pclass][mem].address)
-                               kvfree(mem_params->params[pclass][mem].address);
+                       kvfree(mem_params->params[pclass][mem].address);
                        if (css_params->params[pclass][mem].address)
                                hmm_free(css_params->params[pclass][mem].address);
                        mem_params->params[pclass][mem].address = NULL;