fbdev/carminefb: Use fbdev I/O helpers
authorThomas Zimmermann <tzimmermann@suse.de>
Thu, 3 Aug 2023 18:35:31 +0000 (20:35 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Fri, 4 Aug 2023 13:54:35 +0000 (15:54 +0200)
Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
* use _IOMEM_ in commit message
v2:
* updated to use _IOMEM_ tokens

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-7-tzimmermann@suse.de
drivers/video/fbdev/Kconfig
drivers/video/fbdev/carminefb.c

index ea24f8114ac7b8bf7e4ce4602e1b9fc7294a2dab..1fa776cacb899ee2918934564bba0928199612c6 100644 (file)
@@ -1449,9 +1449,7 @@ config FB_PM3
 config FB_CARMINE
        tristate "Fujitsu carmine frame buffer support"
        depends on FB && PCI
-       select FB_CFB_FILLRECT
-       select FB_CFB_COPYAREA
-       select FB_CFB_IMAGEBLIT
+       select FB_IOMEM_HELPERS
        select VIDEO_NOMODESET
        help
          This is the frame buffer device driver for the Fujitsu Carmine chip.
index 33a03f4ae0257c7c6fb6c1e8ff8beeabc8905711..e56065cdba974b4f990b9ab24f483cdcc8beddab 100644 (file)
@@ -530,10 +530,7 @@ static int init_hardware(struct carmine_hw *hw)
 
 static const struct fb_ops carminefb_ops = {
        .owner          = THIS_MODULE,
-       .fb_fillrect    = cfb_fillrect,
-       .fb_copyarea    = cfb_copyarea,
-       .fb_imageblit   = cfb_imageblit,
-
+       FB_DEFAULT_IOMEM_OPS,
        .fb_check_var   = carmine_check_var,
        .fb_set_par     = carmine_set_par,
        .fb_setcolreg   = carmine_setcolreg,