qapi: Tools for sets of special feature flags in generated code
authorMarkus Armbruster <armbru@redhat.com>
Thu, 28 Oct 2021 10:25:15 +0000 (12:25 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Fri, 29 Oct 2021 13:56:29 +0000 (15:56 +0200)
New enum QapiSpecialFeature enumerates the special feature flags.

New helper gen_special_features() returns code to represent a
collection of special feature flags as a bitset.

The next few commits will put them to use.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Message-Id: <20211028102520.747396-5-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
include/qapi/util.h
scripts/qapi/gen.py
scripts/qapi/schema.py

index 257c600f99d7ff03b279193477ebfbbe2ec3c083..7a8d5c7d723714cdc39bd4cf814349fc9e11b636 100644 (file)
 #ifndef QAPI_UTIL_H
 #define QAPI_UTIL_H
 
+typedef enum {
+    QAPI_DEPRECATED,
+} QapiSpecialFeature;
+
 /* QEnumLookup flags */
 #define QAPI_ENUM_DEPRECATED 1
 
index 2ec1e7b3b68b2cfd7e336a8c6f04c40a8aa20c8b..995a97d2b82840f190d4878edc96886cb5c00c5f 100644 (file)
@@ -18,6 +18,7 @@ from typing import (
     Dict,
     Iterator,
     Optional,
+    Sequence,
     Tuple,
 )
 
@@ -29,6 +30,7 @@ from .common import (
     mcgen,
 )
 from .schema import (
+    QAPISchemaFeature,
     QAPISchemaIfCond,
     QAPISchemaModule,
     QAPISchemaObjectType,
@@ -37,6 +39,12 @@ from .schema import (
 from .source import QAPISourceInfo
 
 
+def gen_special_features(features: Sequence[QAPISchemaFeature]) -> str:
+    special_features = [f"1u << QAPI_{feat.name.upper()}"
+                        for feat in features if feat.is_special()]
+    return ' | '.join(special_features) or '0'
+
+
 class QAPIGen:
     def __init__(self, fname: str):
         self.fname = fname
index 6d5f46509a921286d954a90f7e9be1871ca082f6..55f82d7389c4180595f10f76ff6ad401abb77295 100644 (file)
@@ -725,6 +725,9 @@ class QAPISchemaEnumMember(QAPISchemaMember):
 class QAPISchemaFeature(QAPISchemaMember):
     role = 'feature'
 
+    def is_special(self):
+        return self.name in ('deprecated')
+
 
 class QAPISchemaObjectTypeMember(QAPISchemaMember):
     def __init__(self, name, info, typ, optional, ifcond=None, features=None):