Input: da9063 - use dev_err_probe()
authorBiju Das <biju.das.jz@bp.renesas.com>
Fri, 15 Dec 2023 06:05:20 +0000 (22:05 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 15 Dec 2023 06:30:52 +0000 (22:30 -0800)
Replace dev_err()->dev_err_probe() to simplify probe().

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Link: https://lore.kernel.org/r/20231213214803.9931-4-biju.das.jz@bp.renesas.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/da9063_onkey.c

index 5483a0576155d2cda97e1f4a4d72715e051ebc83..a8b7f1cd0ec2a7b5dfcc9a83e4d35a9f66a985c7 100644 (file)
@@ -195,10 +195,9 @@ static int da9063_onkey_probe(struct platform_device *pdev)
        onkey->dev = &pdev->dev;
 
        onkey->regmap = dev_get_regmap(pdev->dev.parent, NULL);
-       if (!onkey->regmap) {
-               dev_err(&pdev->dev, "Parent regmap unavailable.\n");
-               return -ENXIO;
-       }
+       if (!onkey->regmap)
+               return dev_err_probe(&pdev->dev, -ENXIO,
+                                    "Parent regmap unavailable.\n");
 
        onkey->key_power = !of_property_read_bool(pdev->dev.of_node,
                                                  "dlg,disable-key-power");
@@ -228,11 +227,9 @@ static int da9063_onkey_probe(struct platform_device *pdev)
                                          NULL, da9063_onkey_irq_handler,
                                          IRQF_TRIGGER_LOW | IRQF_ONESHOT,
                                          "ONKEY", onkey);
-       if (error) {
-               dev_err(&pdev->dev,
-                       "Failed to request IRQ %d: %d\n", irq, error);
-               return error;
-       }
+       if (error)
+               return dev_err_probe(&pdev->dev, error,
+                                    "Failed to allocate onkey IRQ\n");
 
        error = dev_pm_set_wake_irq(&pdev->dev, irq);
        if (error)