scsi: qedf: Remove set but not checked variable 'tmp'
authorLee Jones <lee.jones@linaro.org>
Mon, 13 Jul 2020 07:46:25 +0000 (08:46 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 15 Jul 2020 20:01:57 +0000 (16:01 -0400)
Looks like the return value of readw() has never been checked.

Fixes the following W=1 kernel build warning(s):

 drivers/scsi/qedf/qedf_main.c: In function ‘__qedf_probe’:
 drivers/scsi/qedf/qedf_main.c:3203:6: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable]

Link: https://lore.kernel.org/r/20200713074645.126138-10-lee.jones@linaro.org
Cc: QLogic-Storage-Upstream@cavium.com
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qedf/qedf_main.c

index a77a74fad6a7e06163e20e6de734c39d4fca73f5..47fc14f5ed9d744e7847da6d330a025ea38dd4ec 100644 (file)
@@ -3199,7 +3199,6 @@ static int __qedf_probe(struct pci_dev *pdev, int mode)
        void *task_start, *task_end;
        struct qed_slowpath_params slowpath_params;
        struct qed_probe_params qed_params;
-       u16 tmp;
 
        /*
         * When doing error recovery we didn't reap the lport so don't try
@@ -3393,9 +3392,9 @@ static int __qedf_probe(struct pci_dev *pdev, int mode)
            "Writing %d to primary and secondary BDQ doorbell registers.\n",
            qedf->bdq_prod_idx);
        writew(qedf->bdq_prod_idx, qedf->bdq_primary_prod);
-       tmp = readw(qedf->bdq_primary_prod);
+       readw(qedf->bdq_primary_prod);
        writew(qedf->bdq_prod_idx, qedf->bdq_secondary_prod);
-       tmp = readw(qedf->bdq_secondary_prod);
+       readw(qedf->bdq_secondary_prod);
 
        qed_ops->common->set_power_state(qedf->cdev, PCI_D0);