ASoC: audio-graph-card2: remove unneeded of_node_get()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thu, 9 May 2024 00:33:11 +0000 (00:33 +0000)
committerMark Brown <broonie@kernel.org>
Thu, 9 May 2024 04:59:23 +0000 (06:59 +0200)
"lnk" is used as "port0", and it will be used to get "port1" by
of_get_next_child(ports, lnk). It will call of_node_put() inside. This
function is calling of_node_get() to make up for it, but it doesn't call
paired of_node_put(port0) when it quit function.
This of_node_get() itself is not needed, let's remove it.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87jzk3akoo.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/generic/audio-graph-card2.c

index 62606e20be9a3ec0e9607e4da1acd68e99f9ba1a..c4d52fadebb62df6db8694d66c14c4152af39762 100644 (file)
@@ -1203,8 +1203,6 @@ static int graph_count_c2c(struct simple_util_priv *priv,
        struct device_node *codec0 = of_graph_get_remote_port(ep0);
        struct device_node *codec1 = of_graph_get_remote_port(ep1);
 
-       of_node_get(lnk);
-
        /*
         * codec2codec {
         *      ports {