crypto: qat - remove unneeded assignment
authorGiovanni Cabiddu <giovanni.cabiddu@intel.com>
Fri, 4 Mar 2022 18:03:54 +0000 (18:03 +0000)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 9 Mar 2022 03:12:32 +0000 (15:12 +1200)
The function adf_gen4_get_vf2pf_sources() computes a mask which is
stored in a variable which is returned and not used.
Remove superfluous assignment of variable.

This is to fix the following warning when compiling the QAT driver
with clang scan-build:

    drivers/crypto/qat/qat_common/adf_gen4_pfvf.c:46:9: warning: Although the value stored to 'sou' is used in the enclosing expression, the value is never actually read from 'sou' [deadcode.DeadStores]
            return sou &= ~mask;
                   ^      ~~~~~

Fixes: 5901b4af6e07 ("crypto: qat - fix access to PFVF interrupt registers for GEN4")
Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/qat/qat_common/adf_gen4_pfvf.c

index 3b3ea849c5e53b726a6f254da123bd6b92c85b50..d80d493a775689380e46410f3658d26e026ccd2b 100644 (file)
@@ -43,7 +43,7 @@ static u32 adf_gen4_get_vf2pf_sources(void __iomem *pmisc_addr)
        sou = ADF_CSR_RD(pmisc_addr, ADF_4XXX_VM2PF_SOU);
        mask = ADF_CSR_RD(pmisc_addr, ADF_4XXX_VM2PF_MSK);
 
-       return sou &= ~mask;
+       return sou & ~mask;
 }
 
 static void adf_gen4_enable_vf2pf_interrupts(void __iomem *pmisc_addr,