memory: tegra: Delete dead debugfs checking code
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 9 Jun 2021 09:55:25 +0000 (12:55 +0300)
committerKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Thu, 10 Jun 2021 07:18:15 +0000 (09:18 +0200)
The debugfs_create_dir() function does not return NULL, it returns error
pointers.  But in normal situations like this where the caller is not
dereferencing "emc->debugfs.root" then we are not supposed to check the
return.  So instead of fixing these checks, we should delete them.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YMCQDTSyG8UuQoh0@mwanda
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
drivers/memory/tegra/tegra124-emc.c
drivers/memory/tegra/tegra20-emc.c
drivers/memory/tegra/tegra210-emc-core.c
drivers/memory/tegra/tegra30-emc.c

index a21ca8e0841aa83239c6aa0d8e8170c86bd93f3e..908f8d5392b219d2450b5047c9f5ec15d0640ec2 100644 (file)
@@ -1269,10 +1269,6 @@ static void emc_debugfs_init(struct device *dev, struct tegra_emc *emc)
        }
 
        emc->debugfs.root = debugfs_create_dir("emc", NULL);
-       if (!emc->debugfs.root) {
-               dev_err(dev, "failed to create debugfs directory\n");
-               return;
-       }
 
        debugfs_create_file("available_rates", 0444, emc->debugfs.root, emc,
                            &tegra_emc_debug_available_rates_fops);
index a534197a5fb209aa766db4fa44003a73f81f762a..c3462dbc8c22b032ba5c7c03134f2ef07af9a2eb 100644 (file)
@@ -776,10 +776,6 @@ static void tegra_emc_debugfs_init(struct tegra_emc *emc)
        }
 
        emc->debugfs.root = debugfs_create_dir("emc", NULL);
-       if (!emc->debugfs.root) {
-               dev_err(emc->dev, "failed to create debugfs directory\n");
-               return;
-       }
 
        debugfs_create_file("available_rates", 0444, emc->debugfs.root,
                            emc, &tegra_emc_debug_available_rates_fops);
index 5f224796e32e213d4688cecde07c957b33ddf00c..06c0f17fa429a437dce1a17f62bd9012700b9ecf 100644 (file)
@@ -1759,10 +1759,6 @@ static void tegra210_emc_debugfs_init(struct tegra210_emc *emc)
        }
 
        emc->debugfs.root = debugfs_create_dir("emc", NULL);
-       if (!emc->debugfs.root) {
-               dev_err(dev, "failed to create debugfs directory\n");
-               return;
-       }
 
        debugfs_create_file("available_rates", 0444, emc->debugfs.root, emc,
                            &tegra210_emc_debug_available_rates_fops);
index 63e1983f8a0d7bd028a467f26157464aac0b9da3..7e21a852f2e1ff362f62b5158944567ebe4e2ee1 100644 (file)
@@ -1354,10 +1354,6 @@ static void tegra_emc_debugfs_init(struct tegra_emc *emc)
        }
 
        emc->debugfs.root = debugfs_create_dir("emc", NULL);
-       if (!emc->debugfs.root) {
-               dev_err(emc->dev, "failed to create debugfs directory\n");
-               return;
-       }
 
        debugfs_create_file("available_rates", 0444, emc->debugfs.root,
                            emc, &tegra_emc_debug_available_rates_fops);