cpuacct: Convert BUG_ON() to WARN_ON_ONCE()
authorAndrey Ryabinin <arbn@yandex-team.com>
Mon, 15 Nov 2021 16:46:05 +0000 (19:46 +0300)
committerPeter Zijlstra <peterz@infradead.org>
Tue, 23 Nov 2021 08:55:22 +0000 (09:55 +0100)
Replace fatal BUG_ON() with more safe WARN_ON_ONCE() in cpuacct_cpuusage_read().

Signed-off-by: Andrey Ryabinin <arbn@yandex-team.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com>
Acked-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/20211115164607.23784-2-arbn@yandex-team.com
kernel/sched/cpuacct.c

index 893eece65bfdac52f89ec782b8cfb99be836239e..f347cf9e4634512c163d4b7905b36c177aab87f2 100644 (file)
@@ -106,7 +106,8 @@ static u64 cpuacct_cpuusage_read(struct cpuacct *ca, int cpu,
         * We allow index == CPUACCT_STAT_NSTATS here to read
         * the sum of usages.
         */
-       BUG_ON(index > CPUACCT_STAT_NSTATS);
+       if (WARN_ON_ONCE(index > CPUACCT_STAT_NSTATS))
+               return 0;
 
 #ifndef CONFIG_64BIT
        /*