iwlwifi: dvm: use struct_size over open coded arithmetic

Replace zero-length array with flexible-array member and make use
of the struct_size() helper in kmalloc(). For example:

struct iwl_wipan_noa_data {
    ...
    u8 data[];
};

Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi (CGEL ZTE) <chi.minghao@zte.com.cn>
Link: https://lore.kernel.org/r/20220210060926.1608378-1-chi.minghao@zte.com.cn
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/rx.c b/drivers/net/wireless/intel/iwlwifi/dvm/rx.c
index 895ea75b394f256f4a94d238bb0a99447f78dabe..e9d2717362cf9ad713e51dbaf7a2161d2d7b5b9c 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/dvm/rx.c
+++ b/drivers/net/wireless/intel/iwlwifi/dvm/rx.c
@@ -915,7 +915,7 @@ static void iwlagn_rx_noa_notification(struct iwl_priv *priv,
                len += 1 + 2;
                copylen += 1 + 2;
 
-               new_data = kmalloc(sizeof(*new_data) + len, GFP_ATOMIC);
+               new_data = kmalloc(struct_size(new_data, data, len), GFP_ATOMIC);
                if (new_data) {
                        new_data->length = len;
                        new_data->data[0] = WLAN_EID_VENDOR_SPECIFIC;