powerpc/powernv: Rate limit opal-elog read failure message
authorAndrew Donnellan <ajd@linux.ibm.com>
Fri, 11 Dec 2020 02:11:41 +0000 (13:11 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 15 Dec 2020 11:53:27 +0000 (22:53 +1100)
Sometimes we can't read an error log from OPAL, and we print an error
message accordingly. But the OPAL userspace tools seem to like retrying a
lot, in which case we flood the kernel log with a lot of messages.

Change pr_err() to pr_err_ratelimited() to help with this.

Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20201211021140.28402-1-ajd@linux.ibm.com
arch/powerpc/platforms/powernv/opal-elog.c

index 37b380eef41a4ecfe9a2695e1feb6316602f415d..5821b0fa8614868d420146f3160eb32e2f53046e 100644 (file)
@@ -171,8 +171,8 @@ static ssize_t raw_attr_read(struct file *filep, struct kobject *kobj,
                opal_rc = opal_read_elog(__pa(elog->buffer),
                                         elog->size, elog->id);
                if (opal_rc != OPAL_SUCCESS) {
-                       pr_err("ELOG: log read failed for log-id=%llx\n",
-                              elog->id);
+                       pr_err_ratelimited("ELOG: log read failed for log-id=%llx\n",
+                                          elog->id);
                        kfree(elog->buffer);
                        elog->buffer = NULL;
                        return -EIO;