staging: rtl8723bs: remove assignment in condition in os_dep/ioctl_cfg80211.c

fix the following checkpatch warning:

ERROR: do not use assignment in if condition
1440: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:1440:
+		if ((wps_ie = rtw_get_wps_ie(buf, len, NULL, &wps_ielen)))
--
ERROR: do not use assignment in if condition
2465: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2465:
+		if ((pmgntframe = alloc_mgtxmitframe(pxmitpriv)) == NULL)
--
ERROR: do not use assignment in if condition
2937: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2937:
+	if ((pmgntframe = alloc_mgtxmitframe(pxmitpriv)) == NULL) {
--
ERROR: do not use assignment in if condition
3335: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:3335:
+	if (!(ndev = wdev_to_ndev(wdev)))

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/cc687c2ff614da3e110addd1c5cd610e3356cbd7.1616600897.git.fabioaiuto83@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index 03a784558d79febe163699c63198da7b503be9ad..8deaf98a83dd89ee47b3f4ed8af0523c0026ec7d 100644 (file)
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -1437,7 +1437,8 @@ static int rtw_cfg80211_set_probe_req_wpsp2pie(struct adapter *padapter, char *b
 
        if (len > 0)
        {
-               if ((wps_ie = rtw_get_wps_ie(buf, len, NULL, &wps_ielen)))
+               wps_ie = rtw_get_wps_ie(buf, len, NULL, &wps_ielen);
+               if (wps_ie)
                {
                        #ifdef DEBUG_CFG80211
                        DBG_8192C("probe_req_wps_ielen =%d\n", wps_ielen);
@@ -2462,7 +2463,8 @@ static netdev_tx_t rtw_cfg80211_monitor_if_xmit_entry(struct sk_buff *skb, struc
                        DBG_871X("RTW_Tx:category(%u), action(%u)\n", category, action);
 
                /* starting alloc mgmt frame to dump it */
-               if ((pmgntframe = alloc_mgtxmitframe(pxmitpriv)) == NULL)
+               pmgntframe = alloc_mgtxmitframe(pxmitpriv);
+               if (!pmgntframe)
                        goto fail;
 
                /* update attribute */
@@ -2934,7 +2936,8 @@ static int _cfg80211_rtw_mgmt_tx(struct adapter *padapter, u8 tx_ch, const u8 *b
        }
 
        /* starting alloc mgmt frame to dump it */
-       if ((pmgntframe = alloc_mgtxmitframe(pxmitpriv)) == NULL) {
+       pmgntframe = alloc_mgtxmitframe(pxmitpriv);
+       if (!pmgntframe) {
                /* ret = -ENOMEM; */
                ret = _FAIL;
                goto exit;
@@ -3331,8 +3334,8 @@ void rtw_wdev_unregister(struct wireless_dev *wdev)
 
        if (!wdev)
                return;
-
-       if (!(ndev = wdev_to_ndev(wdev)))
+       ndev = wdev_to_ndev(wdev);
+       if (!ndev)
                return;
 
        adapter = rtw_netdev_priv(ndev);