wifi: iwlwifi: fix EWRD table validity check
authorMiri Korenblit <miriam.rachel.korenblit@intel.com>
Mon, 29 Jan 2024 19:21:49 +0000 (21:21 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Fri, 2 Feb 2024 13:04:42 +0000 (14:04 +0100)
EWRD ACPI table contains up to 3 additional sar profiles.
According to the BIOS spec, the table contains a n_profile
variable indicating how many additional profiles exist in the
table.
Currently we check that n_profiles is not <= 0.
But according to the BIOS spec, 0 is a valid value,
and it can't be < 0 anyway because we receive that from ACPI as
an unsigned integer.

Fixes: 39c1a9728f93 ("iwlwifi: refactor the SAR tables from mvm to acpi")
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Reviewed-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://msgid.link/20240129211905.448ea2f40814.Iffd2aadf8e8693e6cb599bee0406a800a0c1e081@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/fw/acpi.c

index dd68d382d7deed542355b5fe496a3f7db6435637..9be91e6a9882ff724178147342213f9460af1d5b 100644 (file)
@@ -767,7 +767,7 @@ read_table:
         * from index 1, so the maximum value allowed here is
         * ACPI_SAR_PROFILES_NUM - 1.
         */
-       if (n_profiles <= 0 || n_profiles >= ACPI_SAR_PROFILE_NUM) {
+       if (n_profiles >= ACPI_SAR_PROFILE_NUM) {
                ret = -EINVAL;
                goto out_free;
        }