rcu/sync: remove un-used rcu_sync_enter_start function
authorOnkarnath <onkarnath.1@samsung.com>
Thu, 11 Jan 2024 09:27:22 +0000 (14:57 +0530)
committerBoqun Feng <boqun.feng@gmail.com>
Wed, 14 Feb 2024 16:00:57 +0000 (08:00 -0800)
With commit '6a010a49b63a ("cgroup: Make !percpu threadgroup_rwsem
operations optional")' usage of rcu_sync_enter_start is removed.

So this function can also be removed.

In the words of Oleg Nesterov:

__rcu_sync_enter(wait => false) is a better alternative if
someone needs rcu_sync_enter_start() again.

Link: https://lore.kernel.org/all/20220725121208.GB28662@redhat.com/
Signed-off-by: Onkarnath <onkarnath.1@samsung.com>
Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Tejun Heo <tj@kernel.org>
Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
include/linux/rcu_sync.h
kernel/rcu/sync.c

index 0027d4c8087c9ae7aec81e2412a2444a45bf673a..3860dbb9107a2117aa0078c18550aed42d36e241 100644 (file)
@@ -37,7 +37,6 @@ static inline bool rcu_sync_is_idle(struct rcu_sync *rsp)
 }
 
 extern void rcu_sync_init(struct rcu_sync *);
-extern void rcu_sync_enter_start(struct rcu_sync *);
 extern void rcu_sync_enter(struct rcu_sync *);
 extern void rcu_sync_exit(struct rcu_sync *);
 extern void rcu_sync_dtor(struct rcu_sync *);
index e550f97779b8dc82c950bcf92e0676339688c26e..86df878a2fee8b0b78718d8158c23bbb8137fb6f 100644 (file)
@@ -24,22 +24,6 @@ void rcu_sync_init(struct rcu_sync *rsp)
        init_waitqueue_head(&rsp->gp_wait);
 }
 
-/**
- * rcu_sync_enter_start - Force readers onto slow path for multiple updates
- * @rsp: Pointer to rcu_sync structure to use for synchronization
- *
- * Must be called after rcu_sync_init() and before first use.
- *
- * Ensures rcu_sync_is_idle() returns false and rcu_sync_{enter,exit}()
- * pairs turn into NO-OPs.
- */
-void rcu_sync_enter_start(struct rcu_sync *rsp)
-{
-       rsp->gp_count++;
-       rsp->gp_state = GP_PASSED;
-}
-
-
 static void rcu_sync_func(struct rcu_head *rhp);
 
 static void rcu_sync_call(struct rcu_sync *rsp)