kselftest: vm: check errnos in mdwe_test
authorFlorent Revest <revest@chromium.org>
Mon, 28 Aug 2023 15:08:55 +0000 (17:08 +0200)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 6 Oct 2023 21:44:11 +0000 (14:44 -0700)
Invalid prctls return a negative code and set errno.  It's good practice
to check that errno is set as expected.

Link: https://lkml.kernel.org/r/20230828150858.393570-4-revest@chromium.org
Signed-off-by: Florent Revest <revest@chromium.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: Alexey Izbyshev <izbyshev@ispras.ru>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Ayush Jain <ayush.jain3@amd.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: Greg Thelen <gthelen@google.com>
Cc: Joey Gouly <joey.gouly@arm.com>
Cc: KP Singh <kpsingh@kernel.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Peter Xu <peterx@redhat.com>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Szabolcs Nagy <Szabolcs.Nagy@arm.com>
Cc: Topi Miettinen <toiwoton@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
tools/testing/selftests/mm/mdwe_test.c

index 91aa9c3099e7536ee4f09f4c3a62b0bb17ad4db2..1b84cf8e1bbe2b001c25825ae796bd8731a96bf9 100644 (file)
 TEST(prctl_flags)
 {
        EXPECT_LT(prctl(PR_SET_MDWE, 7L, 0L, 0L, 0L), 0);
+       EXPECT_EQ(errno, EINVAL);
        EXPECT_LT(prctl(PR_SET_MDWE, 0L, 7L, 0L, 0L), 0);
+       EXPECT_EQ(errno, EINVAL);
        EXPECT_LT(prctl(PR_SET_MDWE, 0L, 0L, 7L, 0L), 0);
+       EXPECT_EQ(errno, EINVAL);
        EXPECT_LT(prctl(PR_SET_MDWE, 0L, 0L, 0L, 7L), 0);
+       EXPECT_EQ(errno, EINVAL);
 
        EXPECT_LT(prctl(PR_GET_MDWE, 7L, 0L, 0L, 0L), 0);
+       EXPECT_EQ(errno, EINVAL);
        EXPECT_LT(prctl(PR_GET_MDWE, 0L, 7L, 0L, 0L), 0);
+       EXPECT_EQ(errno, EINVAL);
        EXPECT_LT(prctl(PR_GET_MDWE, 0L, 0L, 7L, 0L), 0);
+       EXPECT_EQ(errno, EINVAL);
        EXPECT_LT(prctl(PR_GET_MDWE, 0L, 0L, 0L, 7L), 0);
+       EXPECT_EQ(errno, EINVAL);
 }
 
 FIXTURE(mdwe)