hw/acpi: fix a DSDT table issue when a pxb is present.
authorMarcel Apfelbaum <marcel@redhat.com>
Sun, 17 Jul 2016 16:53:11 +0000 (19:53 +0300)
committerMichael S. Tsirkin <mst@redhat.com>
Thu, 28 Jul 2016 21:07:09 +0000 (00:07 +0300)
PXBs do not support hotplug so they don't have a PCNT function.
Since the PXB's PCI root-bus is a child bus of bus 0, the
build_dsdt code will add a call to the corresponding PCNT function.

Fix this by skipping the PCNT call for the above case.
While at it skip also PCIe child buses.

Reported-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
Tested-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/i386/acpi-build.c

index 77c40d92e25b17bdc715d6b9f3dce5963b9b61bb..5c0d643331a42a9028da0f65737f6315c2bd88d2 100644 (file)
@@ -600,6 +600,10 @@ static void build_append_pci_bus_devices(Aml *parent_scope, PCIBus *bus,
         QLIST_FOREACH(sec, &bus->child, sibling) {
             int32_t devfn = sec->parent_dev->devfn;
 
+            if (pci_bus_is_root(sec) || pci_bus_is_express(sec)) {
+                continue;
+            }
+
             aml_append(method, aml_name("^S%.02X.PCNT", devfn));
         }
     }